Skip to content

Conversation

@ThomasDevoogdt
Copy link

@ThomasDevoogdt ThomasDevoogdt commented Nov 13, 2025

This to support linux headless mode without X11. E.g. A headless server.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28310/head:pull/28310
$ git checkout pull/28310

Update a local copy of the PR:
$ git checkout pull/28310
$ git pull https://git.openjdk.org/jdk.git pull/28310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28310

View PR using the GUI difftool:
$ git pr show -t 28310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28310.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

Hi @ThomasDevoogdt, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ThomasDevoogdt" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@ThomasDevoogdt The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/x11-needed-for-headless branch from 8880f64 to 06b81f2 Compare November 13, 2025 22:48
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/x11-needed-for-headless branch from 06b81f2 to fa548c2 Compare November 14, 2025 08:24
@ThomasDevoogdt
Copy link
Author

Hi @ThomasDevoogdt, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ThomasDevoogdt" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

/covered

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 14, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@ThomasDevoogdt
Copy link
Author

@zhaosongzs I don't know who to address here. I can't create an issue for this PR as I don't have an OpenJDK account. I'm also awaiting OCA.

@ThomasDevoogdt
Copy link
Author

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

Already processed the covered command

@zhaosongzs
Copy link
Member

@robilad will handle your OCA when he is available.

For the jbs issue, you need to ask someone with jbs account to create the issue for you.

@ThomasDevoogdt
Copy link
Author

@robilad will handle your OCA when he is available.

For the jbs issue, you need to ask someone with jbs account to create the issue for you.

@zhaosongzs And who is someone? I'm not affiliated with oracle, I don't know who to address. Ideally I could just leave it from here, and having someone who picks this up for me.

@kevinrushforth
Copy link
Member

@ThomasDevoogdt I recommend you read the OpenJDK Developers' guide, particularly this section on proposing changes to the OpenJDK code. The mailing list on which to discuss this proposed change is client-libs-dev@openjdk.org.

As for the OCA, if you work for an employer who is already an OCA signatory, which is what entering /covered means, no action is needed from you at this time. If you don't, you need to follow the instructions in the OpenJDK Developer's Guide to sign it as an individual contributor, and enter /signed in a comment. Either way, you will need to wait for your OCA to be processed.

@ThomasDevoogdt
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/x11-needed-for-headless branch from fa548c2 to 5a672d0 Compare November 15, 2025 18:24
@openjdk
Copy link

openjdk bot commented Nov 15, 2025

@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@ThomasDevoogdt ThomasDevoogdt changed the title Bugfix/x11 needed for headless Allow compilation without X11 in headless mode. Nov 15, 2025
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org client client-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants