-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Allow compilation without X11 in headless mode. #28310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow compilation without X11 in headless mode. #28310
Conversation
|
Hi @ThomasDevoogdt, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ThomasDevoogdt" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
@ThomasDevoogdt The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
8880f64 to
06b81f2
Compare
|
@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
06b81f2 to
fa548c2
Compare
/covered |
|
@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@zhaosongzs I don't know who to address here. I can't create an issue for this PR as I don't have an OpenJDK account. I'm also awaiting OCA. |
|
/covered |
|
Already processed the |
|
@robilad will handle your OCA when he is available. For the jbs issue, you need to ask someone with jbs account to create the issue for you. |
@zhaosongzs And who is someone? I'm not affiliated with oracle, I don't know who to address. Ideally I could just leave it from here, and having someone who picks this up for me. |
|
@ThomasDevoogdt I recommend you read the OpenJDK Developers' guide, particularly this section on proposing changes to the OpenJDK code. The mailing list on which to discuss this proposed change is client-libs-dev@openjdk.org. As for the OCA, if you work for an employer who is already an OCA signatory, which is what entering |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
fa548c2 to
5a672d0
Compare
|
@ThomasDevoogdt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
This to support linux headless mode without X11. E.g. A headless server.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28310/head:pull/28310$ git checkout pull/28310Update a local copy of the PR:
$ git checkout pull/28310$ git pull https://git.openjdk.org/jdk.git pull/28310/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28310View PR using the GUI difftool:
$ git pr show -t 28310Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28310.diff