Skip to content

Conversation

@honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Nov 13, 2025

This test started to fail on macOS26 due to color inconsistency at certain points.
Color tolerance has been added as a fix.

The color tolerance for the dominant component (eg Color.RED - dominant component is red) is set less (delta /PRIMARY_TOLERANCE = 2) and for non-dominant (For Color.RED - Green and Blue are non-dominant) is set more (delta / TOLERANCE=30). This ensures we are checking for shades (brighter/lighter) of the expected color.

Since the issue is only seen on macOS, I have set both PRIMARY_TOLERANCE & TOLERANCE to 2 on other platforms to keep the test almost close to the original one.

Tested locally on macOS 26.0.1 and 26.1 and fix works as expected.

CI testing on other platforms looks good and no regressions are observed (Link added to JBS).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365426: [macos26] Graphics2D tests fail on new macOS 26 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28312/head:pull/28312
$ git checkout pull/28312

Update a local copy of the PR:
$ git checkout pull/28312
$ git pull https://git.openjdk.org/jdk.git pull/28312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28312

View PR using the GUI difftool:
$ git pr show -t 28312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28312.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365426: [macos26] Graphics2D tests fail on new macOS 26

Reviewed-by: kizune, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0d8b518: 8364560: The default value of --linux-menu-group option is invalid
  • 155d7df: 8371749: New test serviceability/jvmti/events/VMDeath/AllocatingInVMDeath/TestAllocatingInVMDeath.java fails with -Xcheck:jni

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2025
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tolerances seemed to do the trick. Tested on my various devices (including the macOS 26 machine I originally found this issue on) and this passes now. I wonder what in macOS 26 causes the slight color variances when other OS's (including previous macOS versions) don't have this issue.

@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

Going to push as commit 7c169c9.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2025
@openjdk openjdk bot closed this Nov 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@honkar-jdk Pushed as commit 7c169c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants