-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8365426 : [macos26] Graphics2D tests fail on new macOS 26 #28312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back honkar! A progress list of the required criteria for merging this PR into |
|
@honkar-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@honkar-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
azuev-java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
DamonGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tolerances seemed to do the trick. Tested on my various devices (including the macOS 26 machine I originally found this issue on) and this passes now. I wonder what in macOS 26 causes the slight color variances when other OS's (including previous macOS versions) don't have this issue.
|
/integrate |
|
Going to push as commit 7c169c9.
Your commit was automatically rebased without conflicts. |
|
@honkar-jdk Pushed as commit 7c169c9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test started to fail on macOS26 due to color inconsistency at certain points.
Color tolerance has been added as a fix.
The color tolerance for the dominant component (eg Color.RED - dominant component is red) is set less (delta /PRIMARY_TOLERANCE = 2) and for non-dominant (For Color.RED - Green and Blue are non-dominant) is set more (delta / TOLERANCE=30). This ensures we are checking for shades (brighter/lighter) of the expected color.
Since the issue is only seen on macOS, I have set both PRIMARY_TOLERANCE & TOLERANCE to 2 on other platforms to keep the test almost close to the original one.
Tested locally on macOS 26.0.1 and 26.1 and fix works as expected.
CI testing on other platforms looks good and no regressions are observed (Link added to JBS).
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28312/head:pull/28312$ git checkout pull/28312Update a local copy of the PR:
$ git checkout pull/28312$ git pull https://git.openjdk.org/jdk.git pull/28312/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28312View PR using the GUI difftool:
$ git pr show -t 28312Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28312.diff
Using Webrev
Link to Webrev Comment