Skip to content

Conversation

@Anjian-Wen
Copy link
Contributor

@Anjian-Wen Anjian-Wen commented Nov 14, 2025

Support AES CBC intrinsic on RISCV, Already passed the tests in
test/hotspot/jtreg/compiler/codegen/aes/
test/jdk/com/sun/crypto


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371968: RISC-V: implement AES CBC intrinsics (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28320/head:pull/28320
$ git checkout pull/28320

Update a local copy of the PR:
$ git checkout pull/28320
$ git pull https://git.openjdk.org/jdk.git pull/28320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28320

View PR using the GUI difftool:
$ git pr show -t 28320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28320.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@Anjian-Wen The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Anjian-Wen
Copy link
Contributor Author

/issue JDK-8371968

@openjdk openjdk bot changed the title RISC-V: implement AES CBC mode intrinsics 8371968: RISC-V: implement AES CBC intrinsics Nov 17, 2025
@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@Anjian-Wen Anjian-Wen marked this pull request as ready for review November 24, 2025 03:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for making the changes. I am having a look.

// c_rarg4 - input length
//
// Output:
// x0 - input length
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be x10? x0 is the zero register on riscv.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants