-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371968: RISC-V: implement AES CBC intrinsics #28320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@Anjian-Wen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/issue JDK-8371968 |
|
@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
Webrevs
|
RealFYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thanks for making the changes. I am having a look.
| // c_rarg4 - input length | ||
| // | ||
| // Output: | ||
| // x0 - input length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be x10? x0 is the zero register on riscv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, fixed!
Support AES CBC intrinsic on RISCV, Already passed the tests in
test/hotspot/jtreg/compiler/codegen/aes/
test/jdk/com/sun/crypto
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28320/head:pull/28320$ git checkout pull/28320Update a local copy of the PR:
$ git checkout pull/28320$ git pull https://git.openjdk.org/jdk.git pull/28320/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28320View PR using the GUI difftool:
$ git pr show -t 28320Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28320.diff
Using Webrev
Link to Webrev Comment