Skip to content

8371881: C2: Fix potential SEGV in VTransformReductionVectorNode tracing #28323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8371881: C2: Fix potential SEGV in VTransformReductionVectorNode tracing #28323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f694717
8371881: C2: Fix potential SEGV in VTransformReductionVectorNode tracing
vish-chan Nov 14, 2025
0824593
Update src/hotspot/share/opto/vtransform.cpp
vish-chan Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/hotspot/share/opto/vtransform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,6 @@ bool VTransformReductionVectorNode::optimize_move_non_strict_order_reductions_ou
// back to the phi. Check that all non strict order reductions only have a single
// use, except for the last (last_red), which only has phi as a use in the loop,
// and all other uses are outside the loop.
VTransformReductionVectorNode* first_red = this;
VTransformReductionVectorNode* last_red = phi->in_req(2)->isa_ReductionVector();
VTransformReductionVectorNode* current_red = last_red;
while (true) {
Expand All @@ -1264,7 +1263,11 @@ bool VTransformReductionVectorNode::optimize_move_non_strict_order_reductions_ou
tty->print(" Cannot move out of loop, other reduction node does not match:");
print();
tty->print(" other: ");
current_red->print();
if (current_red != nullptr) {
current_red->print();
} else {
tty->print("nullptr");
}
)
return false; // not compatible
}
Expand Down