Skip to content

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Nov 14, 2025

java/net/httpclient/http3/H3RequestRejectedTest.java fails intermittently (rarely) on macOS with javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict.

This is a well known issue on macOS, which can be avoided by having the client bind specifically to the loopback instead of the wildcard.

A couple of methods have been added to HttpServerAdapters (newClientBuilderForH3() / createClientBuilderForH3()) to obtain a client builder pre-configured to bind to the loopback.

Most HTTP/3 test call those methods, but java/net/httpclient/http3/H3RequestRejectedTest.java doesn't, hence the intermittent failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371557: java/net/httpclient/http3/H3RequestRejectedTest.java: javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28326/head:pull/28326
$ git checkout pull/28326

Update a local copy of the PR:
$ git checkout pull/28326
$ git pull https://git.openjdk.org/jdk.git pull/28326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28326

View PR using the GUI difftool:
$ git pr show -t 28326

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28326.diff

Using Webrev

Link to Webrev Comment

…net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371557: java/net/httpclient/http3/H3RequestRejectedTest.java: javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the net net-dev@openjdk.org label Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2025
@dfuch
Copy link
Member Author

dfuch commented Nov 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

Going to push as commit ad38a12.
Since your change was applied there have been 89 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2025
@openjdk openjdk bot closed this Nov 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2025
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@dfuch Pushed as commit ad38a12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants