-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371557: java/net/httpclient/http3/H3RequestRejectedTest.java: javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict #28326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict
|
👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into |
|
@dfuch This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 89 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
jaikiran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
|
/integrate |
|
Going to push as commit ad38a12.
Your commit was automatically rebased without conflicts. |
java/net/httpclient/http3/H3RequestRejectedTest.java fails intermittently (rarely) on macOS with javax.net.ssl.SSLHandshakeException: local endpoint (wildcard) and remote endpoint (loopback) ports conflict.
This is a well known issue on macOS, which can be avoided by having the client bind specifically to the loopback instead of the wildcard.
A couple of methods have been added to HttpServerAdapters (newClientBuilderForH3() / createClientBuilderForH3()) to obtain a client builder pre-configured to bind to the loopback.
Most HTTP/3 test call those methods, but java/net/httpclient/http3/H3RequestRejectedTest.java doesn't, hence the intermittent failure.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28326/head:pull/28326$ git checkout pull/28326Update a local copy of the PR:
$ git checkout pull/28326$ git pull https://git.openjdk.org/jdk.git pull/28326/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28326View PR using the GUI difftool:
$ git pr show -t 28326Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28326.diff
Using Webrev
Link to Webrev Comment