Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 14, 2025

Please review this trivial change that removes the unused NonblockingQueue
utility class and its associated gtests.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371922: Remove unused NonblockingQueue class (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28330/head:pull/28330
$ git checkout pull/28330

Update a local copy of the PR:
$ git checkout pull/28330
$ git pull https://git.openjdk.org/jdk.git pull/28330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28330

View PR using the GUI difftool:
$ git pr show -t 28330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28330.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371922: Remove unused NonblockingQueue class

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3924a28: 8371083: FollowReferences reports non-class objects as JVMTI_HEAP_REFERENCE_SYSTEM_CLASS
  • 58b601a: 8371874: AOTLinkedClassBulkLoader::preload_classes() should not allocate heap objects

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2025

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I tried to use this once because it sounded cool but it didn't solve my problem iirc.

@coleenp
Copy link
Contributor

coleenp commented Nov 14, 2025

It is a trivial change.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2025
@kimbarrett
Copy link
Author

Thank you. I tried to use this once because it sounded cool but it didn't solve my problem iirc.

I kind of remember that.

Thanks for reviewing.

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

Going to push as commit 91b97a4.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3924a28: 8371083: FollowReferences reports non-class objects as JVMTI_HEAP_REFERENCE_SYSTEM_CLASS
  • 58b601a: 8371874: AOTLinkedClassBulkLoader::preload_classes() should not allocate heap objects

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2025
@openjdk openjdk bot closed this Nov 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@kimbarrett Pushed as commit 91b97a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the remove-nonblocking-queue branch November 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants