fix: include width param in Cloudflare image loader to resolve Next.js warnings #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-elicx
reviewed
Nov 9, 2025
pages/cloudflare/howtos/image.mdx
Outdated
| const paramsString = params.join(","); | ||
| if (process.env.NODE_ENV === "development") { | ||
| // Serve the original image when using `next dev` | ||
| return `${src}?${paramsString}`; |
Collaborator
There was a problem hiding this comment.
this wouldn't actually return proper query params since they're joined with a comma.
it's possible that some remote image urls people might use could attempt to interpret that width parameter which would have a value of something like 500,quality=1. Perhaps we should use the ampersand in dev mode so that they're proper query params?
Author
There was a problem hiding this comment.
Thanks for that. I've updated it to use & in dev query params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The custom Cloudflare image loader was causing Next.js warnings in development mode:
This occurred because the loader was returning the raw
srcwithout width parameters whenNODE_ENV === "development", which Next.js interprets as not implementing the width parameter.Summary of Changes
image-loader.tsto includewidthandqualityparams in development mode