Emission-based Neuron Deregistration #2158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnReedV
added
the
skip-cargo-audit
…r/subtensor into refactor-neuron-deregistration
JohnReedV
changed the title
l0r1s
reviewed
Nov 20, 2025
Comment on lines
+28
to
+34
| let rank_keys: Vec<NetUid> = Rank::<T>::iter_keys().collect(); | ||
| let rank_removed = rank_keys.len() as u64; | ||
| total_reads = total_reads.saturating_add(rank_removed); | ||
| for k in rank_keys { | ||
| Rank::<T>::remove(k); | ||
| total_writes = total_writes.saturating_add(1); | ||
| } |
Collaborator
There was a problem hiding this comment.
Using ::clear MultiRemovalResults in one go and the backend/loops fields as reads/writes may be more optimal iterations/memory wise, I'm not sure how many items are there
Comment on lines
+39
to
+45
| let trust_keys: Vec<NetUid> = Trust::<T>::iter_keys().collect(); | ||
| let trust_removed = trust_keys.len() as u64; | ||
| total_reads = total_reads.saturating_add(trust_removed); | ||
| for k in trust_keys { | ||
| Trust::<T>::remove(k); | ||
| total_writes = total_writes.saturating_add(1); | ||
| } |
Comment on lines
+50
to
+56
| let ps_keys: Vec<NetUid> = PruningScores::<T>::iter_keys().collect(); | ||
| let ps_removed = ps_keys.len() as u64; | ||
| total_reads = total_reads.saturating_add(ps_removed); | ||
| for k in ps_keys { | ||
| PruningScores::<T>::remove(k); | ||
| total_writes = total_writes.saturating_add(1); | ||
| } |
Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>
Comment on lines
+522
to
+523
| let min_free: u16 = Self::get_min_non_immune_uids(netuid); | ||
| let can_prune_non_immune = free_count > min_free; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
trust,rankandpruning_scoreand instead selects a neuron for deregistration based onimmunity,emission,reg_block, and thenuidRelated Issue(s)
Fix neuron pruning #1903
Set a minimum number of non-immune, non-immortal UIDs per (sub)subnet #2058