add getProxies in precompile #2207
Conversation
open-junius
added
the
skip-cargo-audit
open-junius
requested review from
JohnReedV,
ales-otf,
camfairchild,
grbIzl,
gztensor,
l0r1s,
sam0x17 and
shamil-gadelshin
precompiles/src/proxy.rs
Outdated
| for proxy in proxies.0 { | ||
| let delegate: [u8; 32] = proxy.delegate.into(); | ||
| result.push(delegate.into()); |
There was a problem hiding this comment.
Can we add the proxytype and the delay here
Returning a struct would be nice
This reverts commit 77a8082.
| Self::SudoUncheckedSetCode => Ok(14), | ||
| Self::SwapHotkey => Ok(15), | ||
| Self::SubnetLeaseBeneficiary => Ok(16), | ||
| Self::RootClaim => Err(()), |
There was a problem hiding this comment.
Is this intentional? I thought we added root claim operations to proxy filter.
| struct ProxyInfo { | ||
| bytes32 delegate; | ||
| uint256 proxy_type; | ||
| uint256 delay; | ||
| } |
There was a problem hiding this comment.
More of a question for my personal knowledge, what is the difference between defining a struct inside the interface scope and out of the interface scope?
| await tx.wait() | ||
| } | ||
|
|
||
| const proxiesAfterAdd = await await api.query.Proxy.Proxies.getValue(convertH160ToSS58(evmWallet4.address)) |
There was a problem hiding this comment.
Is the double await expected here?
| impl TryInto<u8> for ProxyType { | ||
| type Error = (); | ||
|
|
||
| fn try_into(self) -> Result<u8, Self::Error> { | ||
| match self { | ||
| Self::Any => Ok(0), | ||
| Self::Owner => Ok(1), | ||
| Self::NonCritical => Ok(2), | ||
| Self::NonTransfer => Ok(3), | ||
| Self::Senate => Ok(4), | ||
| Self::NonFungible => Ok(5), | ||
| Self::Triumvirate => Ok(6), | ||
| Self::Governance => Ok(7), | ||
| Self::Staking => Ok(8), | ||
| Self::Registration => Ok(9), | ||
| Self::Transfer => Ok(10), | ||
| Self::SmallTransfer => Ok(11), | ||
| Self::RootWeights => Ok(12), | ||
| Self::ChildKeys => Ok(13), | ||
| Self::SudoUncheckedSetCode => Ok(14), | ||
| Self::SwapHotkey => Ok(15), | ||
| Self::SubnetLeaseBeneficiary => Ok(16), | ||
| Self::RootClaim => Err(()), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It is more idiomatic to avoid implementing TryInto directly but implement TryFrom instead because it provides a blanket (automatic) implementation of TryInto.
So if you implement TryFrom<ProxyType> for u8 you get TryInto<u8> for ProxyType for free.
Description
Add getProxies function in precompile.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.