Skip to content

Conversation

@sgonorov
Copy link
Contributor

Removes all "pre-commit" marks

@sgonorov sgonorov self-assigned this Oct 27, 2025
@github-actions github-actions bot added category: visual language Visual language pipeline category: continuous batching Continuous batching category: LLM LLM pipeline (stateful, static) category: whisper Whisper pipeline category: sampling Sampling / Decoding algorithms category: cmake / build Cmake scripts category: tokenizers Tokenizer class or submodule update no-match-files category: GGUF GGUF file reader category: RAG RAG pipeline components category: text streamer category: Speech generation samples labels Oct 27, 2025
@Wovchena Wovchena requested a review from Copilot October 28, 2025 06:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all "pre-commit" test markers from the Python test suite and associated configuration files, simplifying the test execution workflow by eliminating the pre-commit test categorization.

  • Removed @pytest.mark.precommit decorators from test functions across all test files
  • Updated test configuration files to remove pre-commit marker definitions and default test filtering
  • Renamed test function from test_e2e_precommit to test_e2e_lightweight_models to better reflect its purpose
  • Updated documentation to reflect the removal of pre-commit test filtering

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/python_tests/test_whisper_pipeline_static.py Removed 13 @pytest.mark.precommit decorators from whisper static pipeline tests
tests/python_tests/test_whisper_pipeline.py Removed 17 @pytest.mark.precommit decorators from whisper pipeline tests
tests/python_tests/test_vlm_pipeline.py Removed 20 @pytest.mark.precommit decorators from VLM pipeline tests
tests/python_tests/test_tokenizer.py Removed 16 @pytest.mark.precommit decorators from tokenizer tests
tests/python_tests/test_text_streamer.py Removed 2 @pytest.mark.precommit decorators from text streamer tests
tests/python_tests/test_structured_output.py Removed 4 @pytest.mark.precommit decorators from structured output tests
tests/python_tests/test_stateful_speculative_decoding.py Removed 3 @pytest.mark.precommit decorators from speculative decoding tests
tests/python_tests/test_sampling.py Removed 6 @pytest.mark.precommit decorators from sampling tests
tests/python_tests/test_rag.py Removed 9 @pytest.mark.precommit decorators from RAG component tests
tests/python_tests/test_llm_pipeline_static.py Removed 12 @pytest.mark.precommit decorators from static LLM pipeline tests
tests/python_tests/test_llm_pipeline.py Removed 29 @pytest.mark.precommit decorators from LLM pipeline tests
tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_2.py Removed 1 @pytest.mark.precommit decorator from KV cache eviction tests
tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_1.py Removed 3 @pytest.mark.precommit decorators from KV cache eviction tests
tests/python_tests/test_gguf_reader.py Removed 3 @pytest.mark.precommit decorators from GGUF reader tests
tests/python_tests/test_generation_config.py Removed 4 @pytest.mark.precommit decorators from generation config tests
tests/python_tests/test_continuous_batching.py Removed 11 @pytest.mark.precommit decorators and renamed test from test_e2e_precommit to test_e2e_lightweight_models
tests/python_tests/samples/test_text2speech.py Removed 2 @pytest.mark.precommit decorators from text-to-speech sample tests
tests/python_tests/pytest.ini Removed pre-commit marker definition and default addopts filtering
tests/python_tests/conftest.py Simplified pytest configuration by removing pre-commit marker detection logic
tests/python_tests/README.md Updated documentation to remove references to pre-commit test filtering
pyproject.toml Removed pre-commit marker from pytest configuration
Jenkinsfile Removed forceRunPrecommitScope parameter from Jenkins pipeline configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgonorov sgonorov requested a review from Wovchena October 28, 2025 07:36
@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch from b043010 to 2f8094c Compare October 28, 2025 07:38
@Wovchena Wovchena requested a review from Copilot October 28, 2025 07:46
@Wovchena Wovchena enabled auto-merge October 28, 2025 07:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch from 2f8094c to 13f14e4 Compare October 28, 2025 10:52
@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch 2 times, most recently from 419c722 to 2b3e87d Compare November 4, 2025 16:36
@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch 6 times, most recently from 3ad4b5b to a157ada Compare November 6, 2025 11:12
@github-actions github-actions bot added category: speculative decoding Speculative decoding category: LoRA Low rank adapters labels Nov 6, 2025
@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch 5 times, most recently from 34cb39f to 7e72f9b Compare November 10, 2025 07:45
@sgonorov sgonorov force-pushed the test_mark_pre_commit_removal branch from 7e72f9b to 82bca21 Compare November 11, 2025 06:53
@Wovchena Wovchena added this pull request to the merge queue Nov 11, 2025
Merged via the queue into openvinotoolkit:master with commit d4162c4 Nov 11, 2025
96 checks passed
krzyczar pushed a commit to krzyczar/openvino.genai that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: cmake / build Cmake scripts category: continuous batching Continuous batching category: GGUF GGUF file reader category: LLM LLM pipeline (stateful, static) category: LoRA Low rank adapters category: RAG RAG pipeline components category: sampling Sampling / Decoding algorithms category: speculative decoding Speculative decoding category: Speech generation samples category: text streamer category: tokenizers Tokenizer class or submodule update category: visual language Visual language pipeline category: whisper Whisper pipeline no-match-files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants