-
Notifications
You must be signed in to change notification settings - Fork 303
Pre-commit test mark removal #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-commit test mark removal #2921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all "pre-commit" test markers from the Python test suite and associated configuration files, simplifying the test execution workflow by eliminating the pre-commit test categorization.
- Removed
@pytest.mark.precommitdecorators from test functions across all test files - Updated test configuration files to remove pre-commit marker definitions and default test filtering
- Renamed test function from
test_e2e_precommittotest_e2e_lightweight_modelsto better reflect its purpose - Updated documentation to reflect the removal of pre-commit test filtering
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/python_tests/test_whisper_pipeline_static.py | Removed 13 @pytest.mark.precommit decorators from whisper static pipeline tests |
| tests/python_tests/test_whisper_pipeline.py | Removed 17 @pytest.mark.precommit decorators from whisper pipeline tests |
| tests/python_tests/test_vlm_pipeline.py | Removed 20 @pytest.mark.precommit decorators from VLM pipeline tests |
| tests/python_tests/test_tokenizer.py | Removed 16 @pytest.mark.precommit decorators from tokenizer tests |
| tests/python_tests/test_text_streamer.py | Removed 2 @pytest.mark.precommit decorators from text streamer tests |
| tests/python_tests/test_structured_output.py | Removed 4 @pytest.mark.precommit decorators from structured output tests |
| tests/python_tests/test_stateful_speculative_decoding.py | Removed 3 @pytest.mark.precommit decorators from speculative decoding tests |
| tests/python_tests/test_sampling.py | Removed 6 @pytest.mark.precommit decorators from sampling tests |
| tests/python_tests/test_rag.py | Removed 9 @pytest.mark.precommit decorators from RAG component tests |
| tests/python_tests/test_llm_pipeline_static.py | Removed 12 @pytest.mark.precommit decorators from static LLM pipeline tests |
| tests/python_tests/test_llm_pipeline.py | Removed 29 @pytest.mark.precommit decorators from LLM pipeline tests |
| tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_2.py | Removed 1 @pytest.mark.precommit decorator from KV cache eviction tests |
| tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_1.py | Removed 3 @pytest.mark.precommit decorators from KV cache eviction tests |
| tests/python_tests/test_gguf_reader.py | Removed 3 @pytest.mark.precommit decorators from GGUF reader tests |
| tests/python_tests/test_generation_config.py | Removed 4 @pytest.mark.precommit decorators from generation config tests |
| tests/python_tests/test_continuous_batching.py | Removed 11 @pytest.mark.precommit decorators and renamed test from test_e2e_precommit to test_e2e_lightweight_models |
| tests/python_tests/samples/test_text2speech.py | Removed 2 @pytest.mark.precommit decorators from text-to-speech sample tests |
| tests/python_tests/pytest.ini | Removed pre-commit marker definition and default addopts filtering |
| tests/python_tests/conftest.py | Simplified pytest configuration by removing pre-commit marker detection logic |
| tests/python_tests/README.md | Updated documentation to remove references to pre-commit test filtering |
| pyproject.toml | Removed pre-commit marker from pytest configuration |
| Jenkinsfile | Removed forceRunPrecommitScope parameter from Jenkins pipeline configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b043010 to
2f8094c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2f8094c to
13f14e4
Compare
419c722 to
2b3e87d
Compare
3ad4b5b to
a157ada
Compare
34cb39f to
7e72f9b
Compare
7e72f9b to
82bca21
Compare
Removes all "pre-commit" marks
Removes all "pre-commit" marks