-
Notifications
You must be signed in to change notification settings - Fork 302
Correct video_pad tag #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct video_pad tag #2977
Conversation
Signed-off-by: Chen, Peter <peter.chen@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects a typo in the Qwen2-VL video pad tag documentation across multiple files. The tag <video_pad|> was missing the opening pipe character and has been corrected to <|video_pad|> to match the proper format used in other special tokens.
Key Changes:
- Fixed the malformed
<video_pad|>tag to<|video_pad|>in documentation strings - Applied the correction consistently across C++ headers, Python bindings, and type stub files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/python/py_vlm_pipeline.cpp | Updated video_pad tag format in Python docstrings for VLM generate functions |
| src/python/openvino_genai/py_openvino_genai.pyi | Corrected video_pad tag in Python type stub documentation across multiple method signatures |
| src/cpp/include/openvino/genai/visual_language/pipeline.hpp | Fixed video_pad tag in C++ API documentation comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xipingyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I copy them, and miss "|",
0fa4961
<!-- Keep your pull requests (PRs) as atomic as possible. That increases the likelihood that an individual PR won't be stuck because of adjacent problems, merge conflicts, or code review. Your merged PR is going to appear in the automatically generated release notes on GitHub. So the clearer the title the better. --> ## Description A trivial fixing of video_pad tag ## Checklist: - [ ] Tests have been updated or added to cover the new code. <!-- If the change isn't maintenance related, update the tests at https://github.com/openvinotoolkit/openvino.genai/tree/master/tests or explain in the description why the tests don't need an update. --> - [ ] This patch fully addresses the ticket. <!--- If follow-up pull requests are needed, specify in description. --> - [ ] I have made corresponding changes to the documentation. <!-- Run github.com/\<username>/openvino.genai/actions/workflows/deploy_gh_pages.yml on your fork with your branch as a parameter to deploy a test version with the updated content. Replace this comment with the link to the built docs. --> Signed-off-by: Chen, Peter <peter.chen@intel.com>
Description
A trivial fixing of video_pad tag
Checklist: