-
Notifications
You must be signed in to change notification settings - Fork 296
[Docs] Remove LoRA column for not supported use cases, remove duplicated documents & assets #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Docs] Remove LoRA column for not supported use cases, remove duplicated documents & assets #2981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes outdated documentation files and assets, consolidates documentation to a central location, and removes unsupported LoRA-related fields from model configuration files.
Key changes:
- Removes duplicated documentation files (HOW_IT_WORKS.md, DOCKER.md, DEBUG_LOG.md) and associated image assets
- Updates documentation links to point to the centralized documentation site
- Removes
loraSupportfield from model type definitions for Whisper, VLM, and Speech Generation models
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/docs/stateless.jpg | Removed duplicated image asset |
| src/docs/stateful.jpg | Removed duplicated image asset |
| src/docs/beam_idx-fork.gif | Removed duplicated image asset |
| src/docs/beam_idx-drop.gif | Removed duplicated image asset |
| src/docs/HOW_IT_WORKS.md | Removed duplicated documentation file |
| src/docs/DOCKER.md | Removed duplicated documentation file |
| src/docs/DEBUG_LOG.md | Removed duplicated documentation file |
| src/README.md | Updated documentation links to point to centralized site |
| site/docs/supported-models/_components/whisper-models-table/models.ts | Removed unsupported loraSupport field from model type |
| site/docs/supported-models/_components/vlm-models-table/models.ts | Removed unsupported loraSupport field from model type |
| site/docs/supported-models/_components/speech-generation-models-table/models.ts | Removed unsupported loraSupport field from model type |
| site/docs/guides/debug-logging.mdx | Added GGUF model debug logging documentation |
| README.md | Updated image reference path to centralized location |
| .github/CONTRIBUTING.md | Updated documentation links to use absolute paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| models: [ | ||
| { | ||
| name: 'SpeechT5 TTS', | ||
| loraSupport: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are notes for some of the pipelines
LoRA adapters are not supported.
Add them to other pipelines.
LLMs should extend their note
Other models with similar architectures may also work
with LoRA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added lora support notes for each use case, preview updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR removes outdated documentation files and assets, consolidates documentation to a central location, and removes unsupported LoRA-related fields from model configuration files.
Preview: https://yatarkan.github.io/openvino.genai/docs/supported-models/#visual-language-models-vlms
Checklist: