Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

API review suggested tweaking the working and adding the // +unionMember annotation to the inline configuration.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Copilot AI review requested due to automatic review settings November 28, 2025 15:23
@perdasilva perdasilva requested a review from a team as a code owner November 28, 2025 15:23
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 5067091
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6929be7b2a0293000871aac7
😎 Deploy Preview https://deploy-preview-2366--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from bentito and dtfranz November 28, 2025 15:23
@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86, grokspawn, michaelryanpeter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva changed the title Update inline config docs and annotations 🌱 Update inline config docs and annotations Nov 28, 2025
Copilot finished reviewing on behalf of perdasilva November 28, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the inline configuration documentation and adds the +unionMember annotation to the ClusterExtensionConfig.Inline field as suggested by an API review. The changes make the documentation clearer, fix a grammatical error in the original text, and ensure proper union type annotation for the Kubernetes API.

Key Changes:

  • Rewrote inline configuration documentation for better clarity and grammar
  • Added // +unionMember annotation to the Inline field in ClusterExtensionConfig
  • Updated all generated CRD manifests and API documentation to reflect the source changes

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
api/v1/clusterextension_types.go Updated inline configuration documentation comments and added +unionMember annotation
manifests/experimental.yaml Generated CRD manifest updated with new documentation text
manifests/experimental-e2e.yaml Generated E2E CRD manifest updated with new documentation text
helm/olmv1/base/operator-controller/crd/experimental/olm.operatorframework.io_clusterextensions.yaml Helm CRD manifest updated with new documentation text
docs/api-reference/olmv1-api-reference.md API reference documentation updated to match source code comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant