Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 3, 2025

…g upgrade (#2362)"

This is causing an issue with multi-node upgrades downstream.

This reverts commit 5ed8cf4.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

…g upgrade (operator-framework#2362)"

This is causing an issue with multi-node upgrades downstream.

This reverts commit 5ed8cf4.
@tmshort tmshort requested a review from a team as a code owner December 3, 2025 18:18
@openshift-ci openshift-ci bot requested review from OchiengEd and pedjak December 3, 2025 18:18
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort changed the title Revert "add PDB to make sure at least 1 pod is always available durin… 🐛 Revert "add PDB to make sure at least 1 pod is always available durin… Dec 3, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Dec 3, 2025

/hold

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 06aaa45
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69307eef03a86b00084501a6
😎 Deploy Preview https://deploy-preview-2370--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.54%. Comparing base (4e349e6) to head (06aaa45).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2370      +/-   ##
==========================================
+ Coverage   70.61%   74.54%   +3.93%     
==========================================
  Files          95       95              
  Lines        7375     7375              
==========================================
+ Hits         5208     5498     +290     
+ Misses       1728     1439     -289     
+ Partials      439      438       -1     
Flag Coverage Δ
e2e 44.58% <ø> (-0.06%) ⬇️
experimental-e2e 48.91% <ø> (?)
unit 58.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Dec 4, 2025

Closing, as it's not needed.

@tmshort tmshort closed this Dec 4, 2025
@tmshort tmshort deleted the revert branch December 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant