-
Notifications
You must be signed in to change notification settings - Fork 68
⚠️ Remove Paused ClusterExtensionRevision LifecycleState #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove Paused ClusterExtensionRevision LifecycleState #2373
Conversation
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the "Paused" lifecycle state from the ClusterExtensionRevision API, simplifying the lifecycle model to only support "Active" and "Archived" states. The removal is comprehensive, eliminating the constant definition, related controller logic, and boxcutter integration code.
- Removed the
ClusterExtensionRevisionLifecycleStatePausedconstant and its documentation - Removed controller logic that handled paused state (boxcutter
WithPausedoption) - Simplified revision filtering logic to only skip archived revisions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
api/v1/clusterextensionrevision_types.go |
Removed the ClusterExtensionRevisionLifecycleStatePaused constant and its documentation |
internal/operator-controller/controllers/clusterextensionrevision_controller.go |
Removed the conditional logic that added boxcutter.WithPaused option for paused revisions |
internal/operator-controller/controllers/boxcutter_reconcile_steps.go |
Simplified from a switch statement to a simple conditional check, now only skipping archived revisions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
==========================================
+ Coverage 72.26% 74.86% +2.60%
==========================================
Files 95 95
Lines 7336 7332 -4
==========================================
+ Hits 5301 5489 +188
+ Misses 1631 1409 -222
- Partials 404 434 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
rashmigottipati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override go-apidiff |
|
@perdasilva: Overrode contexts on behalf of perdasilva: go-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8176ce2
into
operator-framework:main
Description
Removes references from the ClusterExtensionRevision Paused lifecycle state, since we don't plan on including it for now
Reviewer Checklist