fix(core): generate correct enum types when combining enums #2057
Conversation
soartec-lab
left a comment
soartec-lab
left a comment
There was a problem hiding this comment.
@AllieJonsson
Thank you in advance. I added several comments.
packages/core/src/getters/combine.ts
Outdated
| if (isRef[0]) { | ||
| return values[0]; | ||
| } | ||
| const getEnumImplementation = ( |
There was a problem hiding this comment.
Since we want to consolidate enum definitions into one file, getEnumImplementation, getEnumImplementation, and getCombineEnumValue should be moved to enum.ts 👍
There was a problem hiding this comment.
@AllieJonsson
Can we move getCombineEnumValue as well?
There was a problem hiding this comment.
Sorry, I forgot it
|
Well crap, this build error is probably difficult to fix, Im not sure we have the data we need at the point we need it... Ill look into it later today |
|
|
||
| let enumValue = `[${joindEnumValues}]`; | ||
| if (context.output.override.enumGenerationType === EnumGeneration.ENUM) { | ||
| if (item.isRef || existingReferencedProperties.length === 0) { |
There was a problem hiding this comment.
so type annotations are no longer possible.
Is this a temporary fix? Or will it become permanent?
There was a problem hiding this comment.
It is temporary, I will mark this as a draft as there are more issues that needs to be fixed in #2065
3 participants
Status
READY
Description
Fixes #2010