BDD tests: change handling of untagged nodes #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodes defined in the grid are now added to the import data only when the grid is defined, not when the final OPL is generated. This avoids untagged nodes being added again when running updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BDD tests have the hidden feature that they implicitly add any nodes defined in the grid to the import data. This leads to a bit off odd behaviour for tests that have an update phase: you have to unset the grid in order to avoid untagged nodes being added during update.
This PR changes the behaviour: nodes defined in the grid are now added to the import data only when the grid is defined, not when the final OPL is generated. So, nodes from the grid will still appear in the import data but only once.