-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
ENH: Implement option 'truncate' of argument if_exists in DataFrame.to_sql
#59391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement option 'truncate' of argument if_exists in DataFrame.to_sql
#59391
Conversation
| raise ValueError(f"Table '{table_name}' already exists.") | ||
| elif if_exists == "replace": | ||
| with self.con.cursor() as cur: | ||
| cur.execute(f"DROP TABLE {table_name}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we should use mode=replace instead of running a manual DROP TABLE statement. I can have other PR for this patch if it makes sense...
d262bb4 to
e8dee05
Compare
to_sql APIif_exists in DataFrame.to_sql
ad21c3b to
eced22f
Compare
eced22f to
bd8c8ca
Compare
bd8c8ca to
29346ff
Compare
if_exists in DataFrame.to_sqlif_exists in DataFrame.to_sql
4e93848 to
e4b196a
Compare
e4b196a to
bce011a
Compare
ce619c7 to
bf9f21c
Compare
|
Hi @erfannariman o/.
Thanks in advance. |
I reacted in the PR. Let's wait a couple days to see if we get some responses from others. If not, feel free to ping me again. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
The best option here is to close this PR. The community and the maintainers couldn't reach consensus over the feature in a timely manner - despite my efforts. I will be happy to work in this feature once we achieve that. |
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.