CLN: Use dedup_names for column name mangling in Python parser (#50371) #61670
+3
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi maintainers 👋 This PR replaces manual deduplication logic with the shared Some CI checks failed due to network-based tests ( Please let me know if you’d like anything else adjusted. Thanks! |
Member
|
can you merge main and see if the CI passes |
| self.dtype.update({col: self.dtype.get(old_col)}) | ||
| this_columns[i] = col | ||
| counts[col] = cur_count + 1 | ||
| from pandas.io.common import dedup_names |
Member
There was a problem hiding this comment.
can this import go at the top of the file
| else: | ||
| cur_count = counts[col] | ||
|
|
||
| if ( |
Member
There was a problem hiding this comment.
looks like this chunk isn't present in dedup_names?
Author
|
Yeah sir, I will try to merge and see if the CI passes
…On Tue, 15 Jul, 2025, 1:34 am jbrockmendel, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/io/parsers/python_parser.py
<#61670 (comment)>:
> - # TODO: Use pandas.io.common.dedup_names instead (see #50371)
- for i in col_loop_order:
- col = this_columns[i]
- old_col = col
- cur_count = counts[col]
-
- if cur_count > 0:
- while cur_count > 0:
- counts[old_col] = cur_count + 1
- col = f"{old_col}.{cur_count}"
- if col in this_columns:
- cur_count += 1
- else:
- cur_count = counts[col]
-
- if (
looks like this chunk isn't present in dedup_names?
—
Reply to this email directly, view it on GitHub
<#61670 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCH5XYIIYOXP5ISXTVC73533IQEOLAVCNFSM6AAAAAB7NLXPE2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJXGYYTGNBXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Author
|
I'm working on it and I will able to finish it in week
Thank you
…On Sat, 16 Aug, 2025, 5:38 am github-actions[bot], ***@***.***> wrote:
*github-actions[bot]* left a comment (pandas-dev/pandas#61670)
<#61670 (comment)>
This pull request is stale because it has been open for thirty days with
no activity. Please update
<https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request>
and respond to this comment if you're still interested in working on this.
—
Reply to this email directly, view it on GitHub
<#61670 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCH5XYOBUM2JAAZECJUQDH33NZZABAVCNFSM6AAAAAB7NLXPE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOJTGAZTKMJQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Closing to clear the queue. Can re-open when you're ready to continue here. |
Author
|
I'm ready.
…On Sat, Sep 20, 2025 at 6:33 AM jbrockmendel ***@***.***> wrote:
*jbrockmendel* left a comment (pandas-dev/pandas#61670)
<#61670 (comment)>
Closing to clear the queue. Can re-open when you're ready to continue here.
—
Reply to this email directly, view it on GitHub
<#61670 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCH5XYIMH5PNFCTKY4N3USL3TSRXDAVCNFSM6AAAAAB7NLXPE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJUGMZTCMJTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
@Veneel77 you said you're ready to continue. can you address the comments and get the CI passing? |
Author
|
Follow-up on Pandas Issue
Hi jbrockmendel,
Thanks for the reminder! I’m currently a bit occupied with some coursework,
but I’ll make sure to address the comments and get the CI passing within
this week.
Appreciate your patience!
Best,
Veneel ***@***.***)
…On Fri, Oct 31, 2025 at 4:00 AM jbrockmendel ***@***.***> wrote:
*jbrockmendel* left a comment (pandas-dev/pandas#61670)
<#61670 (comment)>
@Veneel77 <https://github.com/Veneel77> you said you're ready to
continue. can you address the comments and get the CI passing?
—
Reply to this email directly, view it on GitHub
<#61670 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCH5XYP24FWQHAUEN75LHX332KGPLAVCNFSM6AAAAAB7NLXPE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINZQGQ4DINBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces manual deduplication logic in the Python parser with the
dedup_namesutility frompandas.io.common.Why is this important?
Checklist