CLN: Add allow_slice to is_hashable function #62567
Open
+59
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LirongMa
changed the title
Member
|
Are there non-test places where this is needed? |
Contributor
Author
not so far. Because in your PR(#53743 (comment)) you added the checks along with the call to is_hashable(). I added this 'allow_slice' argument based on Richard's suggestion (#55152 (comment)) Let me make some changes to some of the callers and set 'allow_slice' to be False. |
LirongMa
commented
Oct 13, 2025
| # This should never be reached, but let's be explicit about it | ||
| raise ValueError("Too many indices") # pragma: no cover | ||
| if all( | ||
| (is_hashable(x) and not _contains_slice(x)) or com.is_null_slice(x) |
Member
There was a problem hiding this comment.
i think this is the only usage of _contains_slice, so that can be removed?
Member
There was a problem hiding this comment.
i think the _contains_slice function still exists a few lines up
| def __hash__(self): | ||
| raise TypeError("Not hashable") | ||
|
|
||
| class HashableSlice: |
Member
There was a problem hiding this comment.
comment that we can get rid of that once we drop py311?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for #55152
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.