BUG: handle nonexistent="shift_forward" with normalize=True in date_range (GH#62602)
#62633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existent="shift_forward"` when crossing DST boundaries
This fixes GH#62602 where `date_range` failed for nonexistent times during
DST transitions due to `Timestamp.normalize` not handling `ambiguous` and
`nonexistent` parameters.
Changes:
- Updated `Timestamp.normalize` (in `_libs/tslibs/timestamps.pyx`):
* Added `ambiguous` and `nonexistent` keyword arguments (defaulting to "raise").
* Passed these parameters to `tz_localize` to properly handle DST-related
ambiguous and nonexistent timestamps.
- Updated type stubs in `timestamps.pyi` to reflect the new method signature.
- Extended `_maybe_normalize_endpoints` (in `core/arrays/datetimes.py`):
* Added support for `ambiguous` and `nonexistent` parameters.
* Updated internal normalization calls to propagate these parameters.
- Updated `DatetimeArray._generate_range` logic to ensure consistent propagation
of `ambiguous` and `nonexistent` through `_maybe_normalize_endpoints` both
before and after timezone handling.
With these changes, `date_range` now correctly handles cases where normalization
intersects DST transitions, preserving expected behavior and avoiding
`NonExistentTimeError` or `AmbiguousTimeError` exceptions.
Co-authored-by: Mohamed Sobhy <msobhyy10@gmail.com>
…iguous times (GH#62602) Add a test in `pandas/tests/arrays/test_datetimes.py` to ensure that `pd.date_range` with `normalize=True` correctly handles DST transitions when both `nonexistent` and `ambiguous` parameters are specified.
msobhyy10
changed the title
pandas.date_range() raises NonExistentTimeError despite nonexistent="shift_forward" when crossing DST boundariesnonexistent="shift_forward" with normalize=True in date_range (GH#62602)
msobhyy10
changed the title
nonexistent="shift_forward" with normalize=True in date_range (GH#62602)pandas.date_range() raises NonExistentTimeError despite nonexistent="shift_forward" when crossing DST boundaries
msobhyy10
changed the title
pandas.date_range() raises NonExistentTimeError despite nonexistent="shift_forward" when crossing DST boundariesnonexistent="shift_forward" with normalize=True in date_range (GH#62602)
3 tasks
Contributor
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.date_range()raisesNonExistentTimeErrordespitenonexistent="shift_forward"when crossing DST boundaries #62602pandas/tests/arrays/test_datetimes.pyto ensurepd.date_rangewithnormalize=Truecorrectly handles DST transitions when bothnonexistentandambiguousparameters are specified.Timestamp.normalize.doc/source/whatsnew/v3.0.0.rst(under Bug fixes / Timezones): mention thatdate_rangenow properly respectsnonexistentandambiguousparameters whennormalize=True.