Skip to content

CLN: replaced ensure_clean with pytest fixture in test_sas.py #62661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

CLN: replaced ensure_clean with pytest fixture in test_sas.py #62661

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa4c1c
replaced ensure_clean with pytest fixture in test_sas.py
Ashutosh2407 Oct 11, 2025
c770006
Merge branch 'main' into replace_ensureclean_test_sas
Ashutosh2407 Oct 15, 2025
0dbb7a9
Merge branch 'main' into replace_ensureclean_test_sas
Ashutosh2407 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/tests/io/sas/test_sas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from pandas import read_sas
import pandas._testing as tm
from pandas.conftest import temp_file
Copy link
Member

@jbrockmendel jbrockmendel Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont import this

Copy link
Author

@Ashutosh2407 Ashutosh2407 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it



class TestSas:
Expand All @@ -18,12 +19,11 @@ def test_sas_buffer_format(self):
with pytest.raises(ValueError, match=msg):
read_sas(b)

def test_sas_read_no_format_or_extension(self):
def test_sas_read_no_format_or_extension(self,temp_file):
# see gh-24548
msg = "unable to infer format of SAS file.+"
with tm.ensure_clean("test_file_no_extension") as path:
with pytest.raises(ValueError, match=msg):
read_sas(path)
with pytest.raises(ValueError, match=msg):
read_sas(temp_file)


def test_sas_archive(datapath):
Expand Down
Loading