Skip to content

TYP: Remove custom ellipsis class #62737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2025
Merged

TYP: Remove custom ellipsis class #62737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions pandas/core/arrays/sparse/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,23 +85,17 @@

from pandas.io.formats import printing

# See https://github.com/python/typing/issues/684
if TYPE_CHECKING:
from collections.abc import (
Callable,
Sequence,
)
from enum import Enum
from types import EllipsisType
from typing import (
Protocol,
type_check_only,
)

class ellipsis(Enum):
Ellipsis = "..."

Ellipsis = ellipsis.Ellipsis

from scipy.sparse import (
csc_array,
csc_matrix,
Expand Down Expand Up @@ -134,10 +128,6 @@ def tocsc(self, /) -> csc_array | csc_matrix: ...
from pandas import Series


else:
ellipsis = type(Ellipsis)


# ----------------------------------------------------------------------------
# Array

Expand Down Expand Up @@ -974,31 +964,22 @@ def __getitem__(self, key: ScalarIndexer) -> Any: ...
@overload
def __getitem__(
self,
key: SequenceIndexer | tuple[int | ellipsis, ...],
key: SequenceIndexer | tuple[int | EllipsisType, ...],
) -> Self: ...

def __getitem__(
self,
key: PositionalIndexer | tuple[int | ellipsis, ...],
key: PositionalIndexer | tuple[int | EllipsisType, ...],
) -> Self | Any:
if isinstance(key, tuple):
key = unpack_tuple_and_ellipses(key)
if key is Ellipsis:
if key is ...:
raise ValueError("Cannot slice with Ellipsis")

if is_integer(key):
return self._get_val_at(key)
elif isinstance(key, tuple):
# error: Invalid index type "Tuple[Union[int, ellipsis], ...]"
# for "ndarray[Any, Any]"; expected type
# "Union[SupportsIndex, _SupportsArray[dtype[Union[bool_,
# integer[Any]]]], _NestedSequence[_SupportsArray[dtype[
# Union[bool_, integer[Any]]]]], _NestedSequence[Union[
# bool, int]], Tuple[Union[SupportsIndex, _SupportsArray[
# dtype[Union[bool_, integer[Any]]]], _NestedSequence[
# _SupportsArray[dtype[Union[bool_, integer[Any]]]]],
# _NestedSequence[Union[bool, int]]], ...]]"
data_slice = self.to_dense()[key] # type: ignore[index]
data_slice = self.to_dense()[key]
elif isinstance(key, slice):
# Avoid densifying when handling contiguous slices
if key.step is None or key.step == 1:
Expand Down
Loading