-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Support for pyarrow version under 22.0.0, hardening for AttributeError #62956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,9 @@ | |
| pa_version_under19p0 = _palv < Version("19.0.0") | ||
| pa_version_under20p0 = _palv < Version("20.0.0") | ||
| pa_version_under21p0 = _palv < Version("21.0.0") | ||
| pa_version_under22p0 = _palv < Version("22.0.0") | ||
| HAS_PYARROW = _palv >= Version(PYARROW_MIN_VERSION) | ||
| except ImportError: | ||
| except (ImportError,AttributeError): | ||
| pa_version_under14p0 = True | ||
| pa_version_under14p1 = True | ||
| pa_version_under15p0 = True | ||
|
|
@@ -29,4 +30,5 @@ | |
| pa_version_under19p0 = True | ||
| pa_version_under20p0 = True | ||
| pa_version_under21p0 = True | ||
| pa_version_under22p0 = True | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we're not using this anywhere, why add it?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You had all the other versions, I admittedly only suggested it for the sake of completeness without thinking too much. Now I had a look at https://arrow.apache.org/release/22.0.0.html to find a reason :-) Maybe to allow CSV headers without quotes? |
||
| HAS_PYARROW = False | ||
Uh oh!
There was an error while loading. Please reload this page.