Skip to content

PERF: missing break in maybe_convert_objects #63067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

PERF: missing break in maybe_convert_objects #63067

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc14321
PERF: missing break in maybe_convert_objects
jbrockmendel Nov 10, 2025
dbe89de
4 breaks down to 1
jbrockmendel Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2725,6 +2725,7 @@ def maybe_convert_objects(ndarray[object] objects,
# e.g. test_out_of_s_bounds_datetime64
seen.object_ = True
break
break
Copy link
Member

@mroeschke mroeschke Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we can remove the 4 breaks here with:

if convert_non_numeric:
    ...
else:
   ...
break

?

Copy link
Member Author

@jbrockmendel jbrockmendel Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will update

else:
seen.object_ = True
break
Expand Down
Loading