BUG: handle overflow in group_sum
#63132
Open
+68
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .noseids | ||
| .ipynb_checkpoints | ||
| .tags | ||
| tags |
Member
Author
There was a problem hiding this comment.
tags is an index file generated by ctags and I use it to navigate in Cython code. I thnk this file should be added to the .gitignore since it's auto generated and shouldn't go into version control.
If you don't want this file going into this PR, I can remove it and create a separate PR for it.
Member
|
perf impact? |
Member
Author
$ asv continuous -E virtualenv:3.13 upstream/main HEAD -b "groupby.*sum" -a repeat=20
| Change | Before [2d73d629] <main> | After [dc6a26cf] <fix/group_sumNaN> | Ratio | Benchmark (Parameter) |
|----------|----------------------------|---------------------------------------|---------|-------------------------------------------------------------------------------------|
| + | 40.6±3ms | 47.7±1ms | 1.17 | groupby.GroupByCythonAgg.time_frame_agg('float64', 'sum') |
| + | 87.2±10μs | 101±0.4μs | 1.15 | groupby.GroupByMethods.time_dtype_as_group('int16', 'sum', 'direct', 1, 'cython') |
| - | 76.5±0.8ms | 69.3±0.5ms | 0.91 | groupby.GroupByCythonAggEaDtypes.time_frame_agg('Float64', 'sum') |
| - | 98.3±2μs | 89.0±10μs | 0.91 | groupby.GroupByMethods.time_dtype_as_group('uint', 'sum', 'direct', 1, 'cython') |
| - | 99.7±2ms | 90.1±2ms | 0.9 | groupby.GroupByCythonAggEaDtypes.time_frame_agg('Int64', 'sum') |
| - | 68.0±2μs | 60.7±8μs | 0.89 | groupby.GroupByMethods.time_dtype_as_group('uint', 'cumsum', 'direct', 1, 'cython') |
| - | 9.26±0.06ms | 8.09±0.1ms | 0.87 | groupby.SumTimeDelta.time_groupby_sum_timedelta |
| - | 15.3±2ms | 12.8±0.1ms | 0.84 | groupby.Cumulative.time_frame_transform('float64', 'cumsum', True) |
| - | 735±20μs | 614±50μs | 0.84 | groupby.GroupByMethods.time_dtype_as_group('float', 'sum', 'direct', 1, 'numba') |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Implementation
Check if value is finite using the C macro
isfiniteand use special verification for complex types.Tests
In the tests,
np.finfo(np.float64).maxis equal tonp.float64(1.7976931348623157e+308)andnp.finfo(np.float64).minis equal tonp.float64(-1.7976931348623157e+308). It requires 3 values to triggerNaN.