-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Parallel include pointers #9861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Moumouls
wants to merge
16
commits into
parse-community:alpha
Choose a base branch
from
Moumouls:moumouls/concurrent-include
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+360
−50
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
daaeed8
fix: mongodb-runner usage and default version to 6.0.2
Moumouls 5811465
fix: json
Moumouls 6e89fd1
feat: parallel include
Moumouls 28ffcd7
Merge branch 'alpha' of github.com:parse-community/parse-server into …
Moumouls 328a4be
Merge branch 'alpha' of github.com:parse-community/parse-server into …
Moumouls 8b99dc5
feat: add test to battle test include
Moumouls d854752
Merge branch 'alpha' into moumouls/concurrent-include
Moumouls c613e3f
Merge branch 'alpha' into moumouls/concurrent-include
mtrezza af50fd3
Merge branch 'alpha' into moumouls/concurrent-include
mtrezza 87339eb
add perf test
mtrezza 2618e96
Merge branch 'alpha' into moumouls/concurrent-include
mtrezza e46dba6
Merge branch 'alpha' into moumouls/concurrent-include
mtrezza b7c919d
Merge branch 'alpha' into moumouls/concurrent-include
mtrezza d432e4c
less verbose
mtrezza bb74681
db proxy
mtrezza 0bef43f
refactor
mtrezza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * Simple TCP proxy to add artificial latency to MongoDB connections | ||
| * This helps make benchmark measurements more stable by simulating network conditions | ||
| */ | ||
|
|
||
| /* eslint-disable no-console */ | ||
|
|
||
| const net = require('net'); | ||
|
|
||
| const PROXY_PORT = parseInt(process.env.PROXY_PORT || '27018', 10); | ||
| const TARGET_HOST = process.env.TARGET_HOST || 'localhost'; | ||
| const TARGET_PORT = parseInt(process.env.TARGET_PORT || '27017', 10); | ||
| const LATENCY_MS = parseInt(process.env.LATENCY_MS || '10', 10); | ||
|
|
||
| const server = net.createServer((clientSocket) => { | ||
| const serverSocket = net.createConnection({ | ||
| host: TARGET_HOST, | ||
| port: TARGET_PORT, | ||
| }); | ||
|
|
||
| // Add latency to data flowing from client to MongoDB | ||
| clientSocket.on('data', (data) => { | ||
| setTimeout(() => { | ||
| if (!serverSocket.destroyed) { | ||
| serverSocket.write(data); | ||
| } | ||
| }, LATENCY_MS); | ||
| }); | ||
|
|
||
| // Add latency to data flowing from MongoDB to client | ||
| serverSocket.on('data', (data) => { | ||
| setTimeout(() => { | ||
| if (!clientSocket.destroyed) { | ||
| clientSocket.write(data); | ||
| } | ||
| }, LATENCY_MS); | ||
| }); | ||
|
|
||
| clientSocket.on('error', () => { | ||
| serverSocket.destroy(); | ||
| }); | ||
|
|
||
| serverSocket.on('error', () => { | ||
| clientSocket.destroy(); | ||
| }); | ||
|
|
||
| clientSocket.on('close', () => { | ||
| serverSocket.destroy(); | ||
| }); | ||
|
|
||
| serverSocket.on('close', () => { | ||
| clientSocket.destroy(); | ||
| }); | ||
| }); | ||
|
|
||
| server.listen(PROXY_PORT, () => { | ||
| console.log(`MongoDB proxy listening on port ${PROXY_PORT} forwarding to ${TARGET_PORT} with ${LATENCY_MS}ms latency`); | ||
| }); | ||
|
|
||
| process.on('SIGTERM', () => { | ||
| server.close(() => { | ||
| process.exit(0); | ||
| }); | ||
| }); | ||
|
|
||
| process.on('SIGINT', () => { | ||
| server.close(() => { | ||
| process.exit(0); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore intended 10 ms latency constant
startProxyexportsLATENCY_MS: '10000', i.e. 10 seconds per packet. With 10 k iterations the include benchmark would take many hours and CI will time out. The surrounding comments and log lines say “10 ms”, so this is a regression. Please drop the extra zeros (or plumb through the intended value).📝 Committable suggestion
🤖 Prompt for AI Agents