EventBroadcaster: Introduce connect & close + Clean code a bit #82
+131
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
2 times, most recently
from
804da6a to
d75208d
Compare
roekatz
changed the title
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
2 times, most recently
from
7f7b9d8 to
7bcbcaa
Compare
roekatz
changed the title
roekatz
force-pushed
the
roe/per-10361-fix-opal-server-eventbroadcaster-integration
branch
from
7bcbcaa to
ee3c2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectmethod is important to be able to retry connections (Specifically from opal server) without using the cumbersome__aenter__