Fix assertion failure when fseeking a phar file out of bounds #20475
+33
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 61884c3 I added these FIXME comments after I noticed that this would cause an assertion failure. At that time I did not yet know what to do here. I took a look at the code now and other streams return -1 and leave the file position untouched. So we do the same for phar. This fixes the assertion failure and subsequent crashes, but also changes one test output. However, I believe the new test output is correct.
Girgias
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 61884c3 I added these FIXME comments after I noticed that this would cause an assertion failure. At that time I did not yet know what to do here. I took a look at the code now and other streams return -1 and leave the file position untouched. So we do the same for phar. This fixes the assertion failure and subsequent crashes, but also changes one test output. However, I believe the new test output is correct.