Zend language scanner: minor refactorings #20480
Open
+29
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
requested changes
Nov 15, 2025
| zend_arena *ast_arena; | ||
| } zend_lex_state; | ||
|
|
||
| typedef struct _zend_heredoc_label { |
Member
There was a problem hiding this comment.
I don't think it makes sense to make these private, as they can be accessed via the public struct via heredoc_label_stack. Similar issue for zend_nest_location.
| #define ZEND_SCANNER_H | ||
|
|
||
| #include "zend_globals.h" | ||
| #include "zend_arena.h" |
Member
There was a problem hiding this comment.
You still include zend_globals, so what exactly do we gain by adding all these headers explicitly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint32_t