Decorate ImpossibleCheckTypeHelper with reason

[VincentLanglet]

Closes phpstan/phpstan#11799

[VincentLanglet]

Since the comparison is between 'publishDate'|'approvedAt'|'allowedValues' and lowercase string, and because of how UnionType::isSuperTypeOfWithReason works

$result = IsSuperTypeOfResult::createNo()->or(...array_map(static fn (Type $innerType) => $innerType->isSuperTypeOfWithReason($otherType), $this->types));
		if ($result->yes()) {
			return $result;
		}

we have a list with three reasons.

Is it ok for you @ondrejmirtes ?

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

Not sure it's a satisfying solution

[ondrejmirtes]

There are conflicts now.

[ondrejmirtes]

Also - maybe base this on 2.1.x now.

[VincentLanglet]

Also - maybe base this on 2.1.x now.

It stopped working on 2.1.x when I rebased for the case

in_array($sortBy, ['publishDate', 'approvedAt', 'allowedValues'], true)

because:

• In 1.12.x, $specifiedTypes->getRootExpr() returns NULL
• In 2.1.x, it now returns PhpParser\Node\Expr\BinaryOp\Identical. So the code used is

$rootExprType = ($this->treatPhpDocTypesAsCertain ? $scope->getType($rootExpr) : $scope->getNativeType($rootExpr));
if ($rootExprType instanceof ConstantBooleanType) {
     return [$rootExprType->getValue(), []];
}

It seems like in_array($sortBy, ['publishDate', 'approvedAt', 'allowedValues'] is now understood as $sortBy === 'publishDate' || $sortBy === 'approvedAt' || $sortBy === 'allowedValues'.

The issue is that when using $rootExprType we don't have the reason.

I dunno if you see a fix/solution and/or if you're still interested in a way by this PR since it might have some inconsistency between when a reason is given and when it's not given @ondrejmirtes ?