Enable FileCacheStorage for OptimizedDirectorySourceLocatorFactory in tests #4576
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the caching in
phpstan-src/src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorFactory.php
Lines 57 to 76 in 1a8a657
re-valides the cache contents via sha1_file() hashes. I think we can utilize this cache also for our test-suite.
running
php tests/vendor/bin/paratest..before this PR:
after this PR:
this will NOT solve phpstan/phpstan#13852 as it only affects the test-suite