Skip to content

Conversation

@dino-rider
Copy link

I had trouble using the module in object oriented code. adding this interface and inheriting from it make it much easier to utilize.

@dino-rider dino-rider marked this pull request as draft February 20, 2023 06:36
@dino-rider dino-rider changed the base branch from master to dev February 20, 2023 06:36
@dino-rider dino-rider changed the base branch from dev to master February 20, 2023 06:37
@dino-rider dino-rider marked this pull request as ready for review February 20, 2023 06:38

#endif

class EspMQTTClient; // forward declaration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed considering that the class definition is 4 rows below?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, probably I just left it there from before. Works fine without it.

@facorazza
Copy link

facorazza commented Jul 29, 2023

This could be a great addition but I have tested the code and it doesn't seem to be functional nor complete

@dino-rider
Copy link
Author

dino-rider commented Jul 31, 2023

I'll update the example to a better one, for now there is a working example using this callback in my other repository https://github.com/dino-rider/IotDevice_test. Also I was working in PlatformIO, but I'm making an arduino example.

@dino-rider dino-rider marked this pull request as draft August 1, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants