Updated empty states across settings #5874
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
- Add show_content? attribute to generic tile component - Ensure content is hidden when toggled off - Avoid rendering border and empty space when toggled off - Fix formatting
sanne-san
commented
Nov 6, 2025
Comment on lines
+166
to
+174
| has_shared_links? = | ||
| Repo.exists?( | ||
| from(l in Plausible.Site.SharedLink, | ||
| where: | ||
| l.site_id == ^site.id and | ||
| l.name not in ^Plausible.Sites.shared_link_special_names() | ||
| ) | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I added this so that I can hide the setting subtitle when the empty state is shown. I'm not sure this is the right place to put it, and it works but requires a page refresh for it to take effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Dark mode