-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement hovertemplate for candlestick and ohlc traces
#7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emilykl
wants to merge
9
commits into
master
Choose a base branch
from
add-hovertemplate-for-candlestick
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+824
−646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdecoster
requested changes
Nov 12, 2025
Contributor
camdecoster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, there's an issue with implementing the split: true logic that makes the split hover info not show up. Could you look into that?
src/traces/ohlc/attributes.js
Outdated
| 'Show hover information (open, close, high, low) in', | ||
| 'separate labels.' | ||
| ].join(' ') | ||
| description: ['Show hover information (open, close, high, low) in', 'separate labels.'].join(' ') |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| description: ['Show hover information (open, close, high, low) in', 'separate labels.'].join(' ') | |
| description: 'Show hover information (open, close, high, low) in separate labels.' |
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
b63fda8 to
6c901b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3437
This PR adds a
hovertemplateattribute forohlcandcandlestick, allowing users to define a custom hover template for those traces.Notes
The first commit of this PR runs the biome formatter which introduces some noise into the diff. Use this link to see only the meaningful changes.
This PR also adds the
hovertemplatefallbackattribute for the two traces in questionhovertemplateis ignored whenhoverlabel.splitis set totrue. (Open to suggestions here but I couldn't see an obvious way to makesplit: truework with thehovertemplateAPI.)One Jasmine test added
This completes the list in #3437, although I'm not sure whether more traces have been added since then which should have a hovertemplate.
Thanks to @chriddyp for putting this on my radar!
To test
hoverlabel.splitis set totrue, the hovertemplate is ignored and the previous behavior is unchanged