fix: fix api path tree building #660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
============================================
+ Coverage 19.79% 19.85% +0.05%
- Complexity 946 950 +4
============================================
Files 375 375
Lines 15598 15607 +9
Branches 1998 2001 +3
============================================
+ Hits 3088 3099 +11
Misses 12125 12125
+ Partials 385 383 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // 跳过第一个为空的str | ||
| TrieNode<String> node = root; | ||
| // 一些场景下（例如dubbo的接口名是com.tencent.polaris.serviceName)，apiPath 不以"/"开头和分割，则直接构造node | ||
| if (apiPaths.length == 1) { |
Member
There was a problem hiding this comment.
如果path是/，那么apiPaths是什么样的？
Contributor
Author
There was a problem hiding this comment.
apiPaths.length为0，仅返回根节点
Contributor
Author
There was a problem hiding this comment.
这里会有个情况是，/path会和path生成同样的树结构。
SkyeBeFreeman
requested changes
Oct 27, 2025
| // 跳过第一个为空的str | ||
| TrieNode<String> node = root; | ||
| // 一些场景下（例如dubbo的接口名是com.tencent.polaris.serviceName)，apiPath 不以"/"开头和分割，则直接构造node | ||
| if (apiPaths.length == 1) { |
fuyuwei01
force-pushed
the
fix-path-building
branch
from
701ea8c to
d628c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.