Skip to content

fix(x-randomvalues): prioritize native RN modules over polyfilled crypto #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

fix(x-randomvalues): prioritize native RN modules over polyfilled crypto #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/x-randomvalues/src/react-native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,18 @@ function getRandomValuesRn (output: Uint8Array): Uint8Array {
);
}

// Check for native RN modules first (highest priority)
const hasNativeRNModules = !!NativeModules['ExpoRandom'] || !!(NativeModules as RNExt).RNGetRandomValues;
const hasNativeCrypto = typeof xglobal.crypto === 'object' && typeof xglobal.crypto.getRandomValues === 'function';

export const getRandomValues = (
(typeof xglobal.crypto === 'object' && typeof xglobal.crypto.getRandomValues === 'function')
? getRandomValuesBrowser
: (typeof xglobal['nativeCallSyncHook'] === 'undefined')
? () => {
hasNativeRNModules
? getRandomValuesRn
: hasNativeCrypto
? getRandomValuesBrowser
: () => {
throw new Error('No secure random number generator available. This environment does not support crypto.getRandomValues.');
}
: getRandomValuesRn
);

export const crypto = (
Expand Down