Skip to content

Conversation

@a-y-a-n-das
Copy link

Resolves #7876

Changes:

  • Added a one-time Friendly Error System (FES) warning for keyCode usage in src/core/main.js.
    • The warning informs users that keyCode is deprecated and suggests using keyIsDown() instead.
  • Added a manual test files: test/manual-test-examples/events/keyCode-warning.html and test/manual-test-examples/events/keyCode-warning-sketch.js
    • Verifies that the warning appears once and key behavior remains unchanged.

Screenshots of the change:

image

PR Checklist

@welcome
Copy link

welcome bot commented Nov 7, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@a-y-a-n-das
Copy link
Author

Hi!
I realized I should’ve claimed this issue first (as per the contributing guidelines), but since it wasn’t assigned to anyone and was still open, I went ahead and fixed it.
Hope that’s okay — please review when you get a chance. I can make any necessary adjustments if needed. 😊

@ksen0 ksen0 self-requested a review November 7, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FES warning for keyCode === usage to help transition from 1.x to 2.0

1 participant