fix!: remove default margin #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I faced the same issue, is there something that blocks the merge? I am eager to contribute then 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default margin applied to SVGs.
This library should not enforce spacing constraints. Whether to add spacing - and how much - should be entirely up to the developer.
THIS IS A BREAKING CHANGE: Some users may have relied on the default spacing. After updating, they will experience minor visual changes, as the SVGs will be slightly smaller. They may experience layout shifts, depending on how their UI was designed, since extra space could now be occupied by unexpected elements.