Skip to content
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
3363ace
Add polo-smm
jesuspolo Jun 25, 2025
ceba758
Apply suggestions from code review
jesuspolo Jun 25, 2025
36c9b43
Update mismatch.py
jesuspolo Jun 25, 2025
eaa90b4
Update mismatch.py
jesuspolo Jun 25, 2025
794ed98
Update mismatch.py
jesuspolo Jun 25, 2025
7926a3d
Update mismatch.py
jesuspolo Jun 25, 2025
988557c
Update mismatch.py
jesuspolo Jul 11, 2025
45e768f
Update mismatch.py
jesuspolo Jul 28, 2025
38e5694
Update pvlib/spectrum/mismatch.py
jesuspolo Jul 28, 2025
c24e013
Update pvlib/spectrum/mismatch.py
jesuspolo Jul 28, 2025
0a00f1b
Changes from code review
AdamRJensen Oct 25, 2025
2a9d0db
Add function to spectrum/__init__.py
AdamRJensen Oct 25, 2025
f296c7b
Update test_mismatch.py
jesuspolo Oct 27, 2025
ce862d8
Update test_mismatch.py
jesuspolo Oct 27, 2025
11336ab
Fix module import in tests
AdamRJensen Oct 27, 2025
e418218
Update test_mismatch.py
jesuspolo Oct 27, 2025
fb0ad0e
Merge branch 'polo-smm' of https://github.com/jesuspolo/pvlib-python …
jesuspolo Oct 27, 2025
450dd37
Fix linter
AdamRJensen Oct 27, 2025
1eb3293
Remove tab character
AdamRJensen Oct 27, 2025
4892e8d
Update test_mismatch.py
jesuspolo Oct 27, 2025
7513f3e
Update test_mismatch.py
jesuspolo Oct 27, 2025
3e4dd56
Update test_mismatch.py
jesuspolo Oct 27, 2025
b9d21ac
fix line legth linter error
AdamRJensen Oct 28, 2025
49c8c91
Update test_mismatch.py
jesuspolo Oct 28, 2025
fa3ff32
Merge branch 'polo-smm' of https://github.com/jesuspolo/pvlib-python …
jesuspolo Oct 28, 2025
31fe508
Update mismatch.py
jesuspolo Oct 29, 2025
c958abf
Update mismatch.py
jesuspolo Nov 14, 2025
bd1ff4f
Apply suggestions from code review
kandersolar Nov 19, 2025
f0a4f34
replace `altitude` parameter with `pressure`
kandersolar Nov 19, 2025
ee7f13f
`albedo : numeric`
kandersolar Nov 19, 2025
82598ec
make albedo coefficients user-specified as well
kandersolar Nov 19, 2025
8b2b7ca
complete tests
kandersolar Nov 19, 2025
31f26b5
docstring cleanup
kandersolar Nov 19, 2025
f4e07de
Merge remote-tracking branch 'upstream/main' into pr/2491
kandersolar Nov 19, 2025
5ec4bee
whatsnew note and contributors
kandersolar Nov 19, 2025
d0efc37
add to user guide SMM model comparison table
kandersolar Nov 19, 2025
297f160
lint
kandersolar Nov 19, 2025
c9b9816
minor doc fixes
kandersolar Nov 19, 2025
3df13ae
Update mismatch.py
jesuspolo Nov 21, 2025
3015b3a
Update mismatch.py
jesuspolo Nov 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions pvlib/spectrum/mismatch.py
Original file line number Diff line number Diff line change
Expand Up @@ -757,47 +757,39 @@
[1]. Polo, J., Sanz-saiz, C., Development of spectral mismatch models
for BIPV applications in building façades Abbreviations : Renew. Energy 245
,122820, 2025.:doi:`10.1016/j.renene.2025.122820`
"""
if module_type is None and coefficients is None:
raise ValueError('Must provide either `module_type` or `coefficients`')
if module_type is not None and coefficients is not None:
raise ValueError('Only one of `module_type` and `coefficients` should '
'be provided')

am_aoi = pvlib.atmosphere.get_relative_airmass(aoi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will produce a nan if aoi > 90.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesuspolo: how should $R_{AM}$ be calculated when the angle of incidence $\theta > 90\degree$ ? I guess something special should be done, but I do not see it specified in the paper.

pressure = pvlib.atmosphere.alt2pres(altitude)
am90 = pvlib.atmosphere.get_absolute_airmass(am_aoi,pressure)
am90 = pvlib.atmosphere.get_absolute_airmass(am_aoi, pressure)
Ram = am90/airmass_absolute

_coefficients = {}
_coefficients = {
'cdte': (-0.0009, 46.80, 49.20, -0.87, 0.00041, 0.053),
'monosi': (0.0027, 10.34, 9.48, 0.307, 0.00077, 0.006),
'cigs': (0.0017, 2.33, 1.30, 0.11, 0.00098, -0.0177),
'asi': (0.0024, 7.32, 7.09, -0.72, -0.0013, 0.089),
}

c = {
'asi': (0.0056, -0.020, 1.014),
'cigs': (-0.0009, -0.0003, 1),
'cdte': (0.0021, -0.01, 1.01),
'monosi': (0, -0.003, 1.0),
}

if module_type is not None:
if module_type is not None:

Check failure on line 783 in pvlib/spectrum/mismatch.py

View workflow job for this annotation

GitHub Actions / flake8-linter

E999 IndentationError: unexpected indent
coeff = _coefficients[module_type]
c_albedo = c[module_type]
else:
coeff = coefficients
c_albedo = (0.0, 0.0, 1.0) # 0.2 albedo assumed
albedo = 0.2

smm = coeff[0] * Ram + coeff[1] / (coeff[2] + Ram**coeff[3]) \
+ coeff[4] / aod500 + coeff[5]*np.sqrt(precipitable_water)

# Ground albedo correction
g = c_albedo[0] * (albedo/0.2)**2 \
+ c_albedo[1] * (albedo/0.2) + c_albedo[2]

return g*smm
Loading