Skip to content

Conversation

@AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I used the APE gallery example for teaching, and students found it confusing that the variable names were inconsistent with the inputs, so I suggest changing it.

@AdamRJensen AdamRJensen added this to the v0.13.2 milestone Oct 21, 2025
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those names were copied from plot_spectrl2_fig51A.py. I was going to suggest that we change them there too, but I think it makes more sense to keep them there since it is tied to the SPECTRL2 report, whereas this example doesn't have that context.

@echedey-ls
Copy link
Contributor

Those names were copied from plot_spectrl2_fig51A.py. I was going to suggest that we change them there too, but I think it makes more sense to keep them there since it is tied to the SPECTRL2 report, whereas this example doesn't have that context.

I agree with you. You can also put AKA comments or link to :term:'s, if some consistency with pvlib's nomenclature is deemed important enough.

@kandersolar kandersolar merged commit bc67019 into main Oct 22, 2025
28 checks passed
@kandersolar kandersolar deleted the AdamRJensen-patch-1 branch October 22, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants