feat: add robust MAD scaler (scale_mad) with tests #1530
Conversation
|
hi @ShachiMistry is there an open issue for this? |
|
@samukweku no worries about an open issue; @ShachiMistry thank you for the PR! |
ericmjl
left a comment
ericmjl
left a comment
There was a problem hiding this comment.
@ShachiMistry thank you for the PR! I've taken a quick look. There's a bit of work on the documentation side that will be needed before we can merge. Would you be open to making those changes please?
| zero_mad: str = "skip", # 'skip' | 'one' | 'raise' | ||
| suffix: Optional[str] = None, | ||
| ) -> pd.DataFrame: | ||
| """Robustly scale numeric columns using Median and MAD.""" |
There was a problem hiding this comment.
Could you bolster the docstrings please? If you're using copilot or other AI systems to assist in coding, you can ask it to study the other functions for the type of material we're looking for in the docstrings, and you'll probably get the right thing, just make sure you review it 😄.
There was a problem hiding this comment.
Could you bump up the docstring coverage here please?
3 participants
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #(put issue number here, and remove parentheses).
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.