undeprecate select columns and select rows #1532
Open
+99
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
🚀 Deployed on https://deploy-preview-1532--pyjanitor.netlify.app |
3 tasks
ericmjl
requested changes
Nov 29, 2025
Member
ericmjl
left a comment
ericmjl
left a comment
There was a problem hiding this comment.
Just a quick question to address.
| from janitor.functions.select import get_index_labels | ||
|
|
||
|
|
||
| @pf.register_groupby_method |
Collaborator
Author
There was a problem hiding this comment.
@ericmjl yes, this has been replaced with @pf.register_dataframe_groupby_method -> @pf.register_dataframe_groupby_method
Member
There was a problem hiding this comment.
Apologies, @samukweku I probably should have been clearer in my phrasing -- I noticed that the whole ungroup function was deleted, is this intentional?
Collaborator
Author
There was a problem hiding this comment.
thanks for the observation @ericmjl ... I have updated the code to show that ungroup is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
select_columnsandselect_rowsfilter_column_isinThis PR resolves #1514.
Please tag maintainers to review.