Skip to content

[Backport maintenance/4.0.x] fix: avoid false positive when module-level names match class-level names #10753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2025
Merged

[Backport maintenance/4.0.x] fix: avoid false positive when module-level names match class-level names #10753

merged 1 commit into from
Nov 22, 2025
+153 −13

Conversation

@pylint-backport
Copy link
Contributor

@pylint-backport pylint-backport bot commented Nov 22, 2025

Backport e55e830 from #10723.

@joao-faria-dev @pylint-backport
fix: avoid false positive when module-level names match class-level n…
f894678 
…ames (#10723)

Add scope comparision to avoid module-level constants to be incorrectly
classified as variables when a class-level attribute with the same name exists

Closes #10719

(cherry picked from commit e55e830)
@codecov
Copy link

codecov bot commented Nov 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (84b6552) to head (f894678).
⚠️ Report is 1 commits behind head on maintenance/4.0.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/4.0.x   #10753   +/-   ##
==================================================
  Coverage              95.97%   95.98%           
==================================================
  Files                    176      176           
  Lines                  19521    19540   +19     
==================================================
+ Hits                   18736    18755   +19     
  Misses                   785      785
Files with missing lines Coverage Δ
pylint/checkers/utils.py 96.03% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.4 milestone Nov 22, 2025
@Pierre-Sassoulas Pierre-Sassoulas merged commit 03f8a92 into maintenance/4.0.x Nov 22, 2025
24 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-10723-to-maintenance/4.0.x branch November 22, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

Bug 🪲

Projects

None yet

Milestone

4.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@Pierre-Sassoulas @joao-faria-dev