update aoc to support 12 stars this year rather than all 25 #164
+37
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonyte
requested changes
Nov 9, 2025
lemonyte
approved these changes
Nov 9, 2025
Co-authored-by: lemonyte <49930425+lemonyte@users.noreply.github.com>
onerandomusername
force-pushed
the
qt/aoc-12
branch
from
149becf to
e795694
Compare
janine9vn
approved these changes
Nov 15, 2025
Collaborator
janine9vn
left a comment
janine9vn
left a comment
There was a problem hiding this comment.
Untested, but looks straightforward and nothing immediately bot breaking.
Conditional approval on issue opening for TODO in code.
| self.loop_task: tasks.Loop | None = None | ||
|
|
||
| self.is_running = False | ||
| self.is_running: bool = False |
Collaborator
There was a problem hiding this comment.
Does this need an annotation? It should be inferable.
Contributor
Author
There was a problem hiding this comment.
I was writing this code with pyright strict mode enabled. I can remove this if that's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #159
closes #160 (aoc daystar currently doesn't take a year as an option)
closes #158