Add related projects, change title to Documentation Translations #158
Conversation
Revert to original view box
|
IMO, this is better suited for a "What are some other projects I can contributed to?" (or similar) Q&A in the FAQ in the devguide. |
templates/base.html.jinja
Outdated
| <a href="./"> | ||
| <img src="logo.png" style="height: 2rem;" alt="Python logo"> | ||
| <span style="font-size: 1.25rem; font-weight: 700; color: #4a4a4a">Translation Dashboard</span> | ||
| <span style="font-size: 1.25rem; font-weight: 700; color: #4a4a4a">Documentation Translations</span> |
There was a problem hiding this comment.
This will now cause wrapping on small screens, e.g.:
So, I'd suggest either adding CSS that centres the hamburger, or maybe just "Docs Translations"?
generate.py
Outdated
| related = env.get_template('related.html.jinja').render() | ||
|
|
||
| Path('build/style.css').write_bytes(Path('src/style.css').read_bytes()) | ||
| Path('build/logo.png').write_bytes(Path('src/logo.png').read_bytes()) |
There was a problem hiding this comment.
Unrelated thought: use shutil.copyfile('src/logo.png', 'build/logo.png')
There was a problem hiding this comment.
Hah, 3.14 allows us to stay with pathlib for the copy, let's try to switch to 3.14? 👀
There was a problem hiding this comment.
Why use a Path object when there is no path manipulation at all? The string paths are already in the source; use shutil and let the kernel do the copy of bytes instead of Python 🙂
(This is extremeley minor relative to the times of cloning and building.)
In my opinion it would be wasting the visibility opportunity, to hide other projects in the devguide. I personally would like this dashboard to aspire to be a homepage for Python ecosystem translation contributors. I think some visitors (by the domain only) would expect to see such information here. |
We now have both. |
Ah, dots in class names 🤦 |
Closes #146.
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/158/merge/