[Executorch] Make module constructors uniform across #15709
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator. Fix that. Differential Revision: [D86120037](https://our.internmc.facebook.com/intern/diff/D86120037/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15709
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New FailuresAs of commit 799c34b with merge base aba44fd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 10, 2025
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
| explicit Module( | ||
| const std::string& file_path, | ||
| const LoadMode load_mode = LoadMode::File, | ||
| std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr, |
Contributor
There was a problem hiding this comment.
nit: method_allocator
Contributor
Author
There was a problem hiding this comment.
oh I see. This is supposed to be called method_allocator?
| const LoadMode load_mode = LoadMode::File, | ||
| std::unique_ptr<runtime::MemoryAllocator> memory_allocator = nullptr, | ||
| std::unique_ptr<runtime::MemoryAllocator> temp_allocator = nullptr, | ||
| std::unique_ptr<runtime::EventTracer> event_tracer = nullptr); |
Contributor
There was a problem hiding this comment.
This is technically a bc breaking change
Contributor
Author
There was a problem hiding this comment.
That is true. Is this part of core API btw given that it is in extension?
I do think we should unify the interface though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Existing constructors dont compose well such that if you want data loader or data files constructor then you cannot get to override memory allocator.
Fix that.
Differential Revision: D86120037