[WIP] Add 2d and 3d indirect indexing support #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yf225
force-pushed
the
indirect_indexing_v2
branch
26 times, most recently
from
28424b9 to
515ad61
Compare
yf225
force-pushed
the
indirect_indexing_v2
branch
3 times, most recently
from
252f6e0 to
37daf60
Compare
yf225
force-pushed
the
indirect_indexing_v2
branch
13 times, most recently
from
9bce34e to
85591df
Compare
yf225
commented
Nov 17, 2025
| return self.block_sizes[rdim_idx] | ||
|
|
||
| def _next_reduction_loop_index(self) -> int: | ||
| return sum(int(info.reduction) for info in self.block_sizes) |
yf225
commented
Nov 17, 2025
| ) -> BlockSizeInfo: | ||
| rdim = self._allocate_new_reduction(size) | ||
| rdim.var = self.block_sizes[block_idx].var | ||
| return rdim |
Contributor
Author
There was a problem hiding this comment.
maybe fold into callers
yf225
commented
Nov 17, 2025
helion/_compiler/ast_extension.py
Outdated
| and prev_rank != new_rank | ||
| ): | ||
| self._type_info = type_info | ||
| return self._type_info |
Contributor
Author
There was a problem hiding this comment.
review whether we actually need this
yf225
force-pushed
the
indirect_indexing_v2
branch
9 times, most recently
from
e8ee215 to
eb7cbac
Compare
yf225
force-pushed
the
indirect_indexing_v2
branch
from
eb7cbac to
ef8e398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546.