Skip to content

Conversation

@angelayi
Copy link
Contributor

@angelayi angelayi commented Sep 8, 2025

Reverts part of #3453 which removed the Custom Class tutorial

Custom classes are a generic concept in PyTorch. Although it was developed for TorchScript, it is also supported in Pytorch 2.0 as many users (like TensorRT and internal Ads frameworks) rely on it. Therefore, we should not delete this tutorial.

Additionally the Custom Class x PT2 tutorial also references this tutorial, although CI did not seem to catch the broken link (cc @svekars)

As part of revert, I removed references to TS.

@angelayi angelayi requested a review from svekars September 8, 2025 23:57
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3546

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e7a3922 with merge base 3cbb0f7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the cla signed label Sep 8, 2025
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM - fix lint?

@angelayi angelayi force-pushed the angelayi/torchbind branch 2 times, most recently from ecf465e to 2431ab1 Compare September 9, 2025 20:48
@angelayi angelayi merged commit 593759e into main Sep 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants