Skip to content

(1/2) Combine Pauli measurements and postselection #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

(1/2) Combine Pauli measurements and postselection #7746

wants to merge 7 commits into from

Conversation

@ddddddanni
Copy link
Collaborator

@ddddddanni ddddddanni commented Nov 11, 2025

I split this #7492 giant PR into smaller pieces for easier review.
This PR:

  1. Adds a CircuitToPauliStringsParameters class which supports postselection_symmetries.
  2. Modify the validation method
  3. Allows measure_pauli_strings to take CircuitToPauliStringsParameters as a input.

@ddddddanni ddddddanni requested review from a team and vtomole as code owners November 11, 2025 19:50
@github-actions github-actions bot added the size: L 250< lines changed <1000 label Nov 11, 2025
@ddddddanni ddddddanni marked this pull request as draft November 11, 2025 19:58
@ddddddanni ddddddanni mentioned this pull request Nov 11, 2025
Draft
eliottrosenberg
eliottrosenberg requested changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't actually apply the postselection, correct? If so, we should raise a NotImplementedError if the user tries to use postselection symmetries.

@ddddddanni ddddddanni marked this pull request as ready for review November 19, 2025 01:10
@ddddddanni
Copy link
Collaborator Author

ddddddanni commented Nov 19, 2025

This PR doesn't actually apply the postselection, correct? If so, we should raise a NotImplementedError if the user tries to use postselection symmetries.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottrosenberg eliottrosenberg eliottrosenberg requested changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton is a code owner automatically assigned from quantumlib/cirq-maintainers

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

size: L 250< lines changed <1000

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddddddanni @eliottrosenberg